Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds exception block to handle invalid storage URL #3695

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

mahajan-xor
Copy link
Contributor

This PR will log information for invalid blob storage URL instead of throwing exception .
It will avoid triggering ICM.

Related issues

Addresses issue https://microsofthealth.visualstudio.com/Health/_workitems/edit/113620/

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mahajan-xor mahajan-xor self-assigned this Jan 31, 2024
@mahajan-xor mahajan-xor requested a review from a team as a code owner January 31, 2024 09:42
@mahajan-xor mahajan-xor added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Jan 31, 2024
@mahajan-xor mahajan-xor added this to the S133 milestone Jan 31, 2024
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mahajan-xor mahajan-xor merged commit 8ce4e6f into main Feb 5, 2024
6 checks passed
@mahajan-xor mahajan-xor deleted the personal/anilm/fhir-importinvalidstorageurlissue branch February 5, 2024 17:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants