Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Tavari/animation explaration #2260

Draft
wants to merge 2 commits into
base: feat/animation-remove-element
Choose a base branch
from

Conversation

TanelVari
Copy link
Contributor

Just forking Maria's branch. Why isn't the unmount animation playing for Popup?

@TanelVari TanelVari requested a review from mnajdova January 17, 2020 23:02
@msftclas
Copy link

msftclas commented Jan 17, 2020

CLA assistant check
All CLA requirements met.

@DustyTheBot
Copy link
Collaborator

Fails
🚫 Non-approved dependencies were detected. It is necessary to obtain approvals and register them in `approvedPackages` file before merge.
Warnings
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.

Changed dependencies in packages/react/package.json

package before after
@fluentui/accessibility ^0.43.0 ^0.42.0
@fluentui/react-bindings ^0.43.0 ^0.42.0
@fluentui/react-component-event-listener ^0.43.0 ^0.42.0
@fluentui/react-component-nesting-registry ^0.43.0 ^0.42.0
@fluentui/react-component-ref ^0.43.0 ^0.42.0
@fluentui/react-proptypes ^0.43.0 ^0.42.0
react-is - ^16.6.3
react-transition-group - ^4.3.0

Non-approved dependencies are detected.

The following package version constraints missing approved candidate:

failed constrains approved candidates
@babel/runtime@^7.5.5 @babel/runtime@7.1.2, @babel/runtime@7.4.5
react-transition-group@^4.3.0 there are no any approved packages
dom-helpers@^5.0.1 there are no any approved packages

Perf comparision

Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
Button.Fluent 1.14 0.12 9.5:1 5000 5691
Checkbox.Fluent 1.28 0.24 5.33:1 5000 6403
Icon.Fluent 0.24 0.03 8:1 5000 1197
Slider.Fluent 1.68 0.24 7:1 5000 8401

Generated by 🚫 dangerJS

@TanelVari TanelVari changed the base branch from master to feat/animation-remove-element January 21, 2020 22:12
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants