This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore: update to Popper v2 #2380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
atomiks
reviewed
Feb 23, 2020
Comment on lines
+109
to
+119
| [ | ||
| /** | ||
| * This prevents blurrines in chrome, when the coordinates are odd numbers alternative | ||
| * would be to use `fn` and manipulate the computed style or ask popper to fix it but | ||
| * since there is presumably only handful of poppers displayed on the page, the | ||
| * performance impact should be minimal. | ||
| */ | ||
| { | ||
| name: 'computeStyles', | ||
| options: { gpuAcceleration: false }, | ||
| }, |
There was a problem hiding this comment.
This shouldn't be required anymore. Popper rounds to the nearest suitable subpixel, and in addition detects the DPI and uses 2D transforms instead of 3D (to preserve subpixel anti-aliasing).
atomiks
reviewed
Feb 23, 2020
Comment on lines
+120
to
+121
| { name: 'flip', options: { padding: 0, flipVariations: true } }, | ||
| { name: 'preventOverflow', options: { padding: 0 } }, |
There was a problem hiding this comment.
These seem redundant as they are the same as the defaults
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.