Rename SwiftUI Color token APIs

[mischreiber]

Platforms Impacted

• iOS
• visionOS
• macOS

Description of changes

PR #2014 introduced a conflicting set of APIs for color, with the hope that most callers Swift callers would auto-resolve to the correct one. We've gotten customer feedback that this is not the case, so to unblock in the short term we'll be renaming the SwiftUI API. Longer-term, we'll come up with better names for both, but this should get folks unblocked quickly.

Binary change

n/a, only a method name change

Verification

Build and basic run of demo app.

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow