Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose Tab Bar Token Pad Height to Consumers #2032

Merged
merged 3 commits into from
May 23, 2024

Conversation

cbowdoin
Copy link
Contributor

@cbowdoin cbowdoin commented May 22, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Exposed a public let of TabBarTokenSet.padHeight for consumers to be able to use if they need to access the iPad height constant for the tab bar view.

Binary change

Total increase: 2,048 bytes
Total decrease: 0 bytes

File Before After Delta
Total 31,258,848 bytes 31,260,896 bytes ⚠️ 2,048 bytes
Full breakdown
File Before After Delta
TabBarView.o 140,080 bytes 141,816 bytes ⚠️ 1,736 bytes
__.SYMDEF 4,881,488 bytes 4,881,800 bytes ⚠️ 312 bytes

Verification

Was able to access the value from an external objective c file.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@cbowdoin cbowdoin requested a review from a team as a code owner May 22, 2024 22:08
@cbowdoin cbowdoin merged commit d2087b4 into microsoft:main May 23, 2024
7 checks passed
@joannaquu joannaquu mentioned this pull request May 30, 2024
12 tasks
@cbowdoin cbowdoin deleted the cbowdoin/TabBarTokenSetObjcExposure branch July 25, 2024 22:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants