Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Calculate Bottom Commanding header height instead of using constant #2041

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented May 31, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Currently, BottomCommandingController's headerContentHeight is hard-coded in as a constant of 66. When the hero item's titles are one line, this is ok. However when it is multi-lined, there is not enough bottom padding. Update it so that headerContentHeight is calculated using systemLayoutSizeFitting.

Binary change

Total increase: 6,072 bytes
Total decrease: 0 bytes

File Before After Delta
Total 31,087,872 bytes 31,093,944 bytes ⚠️ 6,072 bytes
Full breakdown
File Before After Delta
BottomCommandingController.o 837,944 bytes 840,832 bytes ⚠️ 2,888 bytes
__.SYMDEF 4,813,352 bytes 4,815,168 bytes ⚠️ 1,816 bytes
FocusRingView.o 837,864 bytes 839,232 bytes ⚠️ 1,368 bytes

Verification

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner May 31, 2024 22:41
@joannaquu joannaquu merged commit d298dac into microsoft:main Jun 7, 2024
7 checks passed
@joannaquu joannaquu deleted the joannaqu/header-height branch June 7, 2024 17:52
@mischreiber mischreiber mentioned this pull request Jun 24, 2024
3 tasks
lukas-cap pushed a commit to lukas-cap/fluentui-apple that referenced this pull request Jul 17, 2024
joannaquu added a commit to joannaquu/fluentui-apple that referenced this pull request Jul 17, 2024
joannaquu added a commit to joannaquu/fluentui-apple that referenced this pull request Jul 17, 2024
joannaquu added a commit to joannaquu/fluentui-apple that referenced this pull request Jul 26, 2024
joannaquu added a commit that referenced this pull request Jul 27, 2024
… collapsed (#2072)

* Revert "Calculate Bottom Commanding header height instead of using constant (#2041)"

This reverts commit d298dac.

* change headerTopMargin

* set alpha explicitly if not transitioning
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants