Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[List Item] Add animation when adding or removing subtitle/footer #2046

Conversation

alexanderboswell
Copy link
Contributor

@alexanderboswell alexanderboswell commented Jun 15, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

For some scenarios, we will be asynchronously be adding or removing the subtitle for a list item. We dont take advantage of any animations that SwiftUI provides to have a polished transition for the UI.

The changes make it so we can animate based on if the layoutType changes. Also simplify all the scenarios handled by a change in layoutType by defining a few more view builders.

Binary change

All internal API changes, not calculated.

Verification

Visual Verification
Before After
with animation without animation

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@alexanderboswell alexanderboswell marked this pull request as ready for review June 17, 2024 17:47
@alexanderboswell alexanderboswell requested a review from a team as a code owner June 17, 2024 17:47
@alexanderboswell alexanderboswell enabled auto-merge (squash) June 17, 2024 17:47
@joannaquu joannaquu disabled auto-merge June 17, 2024 20:32
@alexanderboswell alexanderboswell enabled auto-merge (squash) June 17, 2024 21:26
@alexanderboswell alexanderboswell merged commit fe0730c into microsoft:main Jun 17, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants