Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tell BottomSheet delegate when user starts to pan the sheet #2077

Merged

Conversation

cbowdoin
Copy link
Contributor

@cbowdoin cbowdoin commented Jul 26, 2024

Platforms Impacted

  • iOS
  • visionOS

Description of changes

Add the delegate method bottomSheetStartedPan to BottomSheetController.swift and invoke it when we begin panning the sheet from the users pan gesture.

Binary change

Total increase: 1,312 bytes
Total decrease: 0 bytes

File Before After Delta
Total 32,302,600 bytes 32,303,912 bytes ⚠️ 1,312 bytes
Full breakdown
File Before After Delta
BottomSheetController.o 544,120 bytes 544,904 bytes ⚠️ 784 bytes
BottomCommandingController.o 865,200 bytes 865,464 bytes ⚠️ 264 bytes
FocusRingView.o 849,608 bytes 849,872 bytes ⚠️ 264 bytes

Verification

Tested by hiding the content of the sheet the sheet when the pan gesture starts.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@cbowdoin cbowdoin requested a review from a team as a code owner July 26, 2024 17:43
@anandrajeswaran anandrajeswaran changed the title Bottom sheet consumers can preform action when user starts to pan the sheet Tell BottomSheet delegate when user starts to pan the sheet Jul 26, 2024
@cbowdoin cbowdoin merged commit 411c8c5 into microsoft:main Jul 26, 2024
7 checks passed
@harrieshin harrieshin mentioned this pull request Aug 16, 2024
12 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants