Add disabled trait to tab bar item view #2079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
When
TabBarItemView
is disabled, VoiceOver/the accessibility inspector do not accurately report that it is disabled. Update it so that we add/remove thenotEnabled
accessibility trait whenisEnabled
changes.Binary change
I no longer trust this at all. I triple checked this and somehow adding traits decreases our binary size??? I also confirmed that I wasn't doing the before/after comparison in the wrong direction.
Total increase: 48 bytes
Total decrease: -368 bytes
Full breakdown
Verification
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow