Switch from sycall to windows #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| oa.ObjectName = &ntPath | ||
| oa.Attributes = windows.OBJ_CASE_INSENSITIVE | ||
|
|
||
| // The security descriptor is only needed for the first pipe. | ||
| if first { | ||
| if sd != nil { | ||
| //todo: does `sdb` need to be allocated on the heap, or can go allocate it? |
There was a problem hiding this comment.
Did you figure this todo out?
There was a problem hiding this comment.
nope, i wasn't able to track it down in the docs or code
i figured we can dig into it in the future, when we clean up the code paths here (and move most of the code to dedicated pkg/pipe dir?)
katiewasnothere
approved these changes
Jul 24, 2023
msscotb
approved these changes
Aug 7, 2023
Where ever possible, use `golang.org/x/sys/windows` instead of `syscall` (which has been deprecated since go1.11). Using `windows.LocalFree` requires using `unsafe.Pointer`, which ensures that the Go garbage collector does not try to free memory pre-maturely if it was previously declared as a pointer. Since `syscall.Handle` is part of API for `vhd` package, it was left unchanged. For security descriptor functions, switch to using `windows.SECURITY_DESCRIPTOR` to avoid unnecessary byte manipulation and panics due to missing input validation and error checking. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where ever possible, use
golang.org/x/sys/windowsinstead ofsyscall(which has been deprecated since go1.11).Using
windows.LocalFreerequires usingunsafe.Pointer, which ensures that the Go garbage collector does not try to free memory pre-maturely if it was previously declared as a pointer.Since
syscall.Handleis part of API forvhdpackage, it was left unchanged.For security descriptor functions, switch to using
windows.SECURITY_DESCRIPTORto avoid unnecessary byte manipulation and panics due to missing input validation and error checking.