-
Notifications
You must be signed in to change notification settings - Fork 256
Commit
Due to some unfortunate deps in the root go.mod in containerd + some k8s staging directory behavior, containerd 1.5 errors out when trying to get vendored into kubernetes/kubernetes. Because we depend on ctrd 1.5, if hcsshim tries to get bumped it will ask that we also bump their dep of containerd to 1.5 and things will fail also. This reverts our containerd dep for the release/0.8 branch to 1.4 so we're able to circumvent this, at least temporarily. Issue tracking this problem that contains k8s proposed solution and statements on this: kubernetes/kubernetes#104827 "Components that have a transitive dependency to anything in k8s.io/kubernetes, including the staging components, can not be added as a dependency. The detection and prevention of this in the dependency management scripts is intentional." While this work is temporary just to get k8s a new hcsshim release, longer term we will need to find a way to trim our containerd dep either here, or containerd will need to get rid of it's k8s.io/* dependencies in their root go.mod to remove this circular import issue. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.