Fix oopsie to not cause files to be skipped #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard (VM) <jhoward@ntdev.microsoft.com>
3 tasks
darstahl
approved these changes
Apr 24, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard (VM) jhoward@ntdev.microsoft.com
Found via docker/for-win#1947, needs re-vendoring into moby/moby after. We shouldn't be returning
SkipDiron a file. With the previous fix for moby/moby 32838, it would returnSkipDironFiles\$Recycle.Bin\$wcidirs$incorrectly. The update checks for an exact filename match, plus verification it is a directory. Have verified locally.@darrenstahlmsft PTAL. @johnstep FYI.