-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
github-ci: use go1.19.x #1689
github-ci: use go1.19.x #1689
Conversation
I ran into this issue a while ago: go1.19 changes the go-doc formatting, specifically with spacing around code blocks. |
Is there a reason that we're moving to 1.19 and not to 1.20 since that's already out? |
I just wanted to get to a minimal version that's required for containerd to run. currently it's failing to build, which I should've probably put in the PR description. |
rerun protobuild Signed-off-by: Maksim An <maksiman@microsoft.com>
039d177
to
fdd5c32
Compare
I forgot about the other issue: hcsshim/pkg/go-runhcs/runhcs.go Lines 38 to 58 in dd66992
|
Signed-off-by: Maksim An <maksiman@microsoft.com>
rerun protobuild fix: check for `exec.ErrDot` Signed-off-by: Maksim An <maksiman@microsoft.com> (cherry picked from commit 66fe5f7) Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
No description provided.