Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace cosesign1 and didx509 resolver with #1805

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Replace cosesign1 and didx509 resolver with #1805

merged 1 commit into from
Jul 14, 2023

Conversation

MahatiC
Copy link
Member

@MahatiC MahatiC commented Jun 6, 2023

... their independent repos

@MahatiC MahatiC force-pushed the replace-repos branch 8 times, most recently from 6a056d7 to 3fa7851 Compare June 8, 2023 10:55
@MahatiC MahatiC force-pushed the replace-repos branch 13 times, most recently from 1dce768 to 22fa3e3 Compare July 11, 2023 12:15
@MahatiC MahatiC marked this pull request as ready for review July 11, 2023 12:52
@MahatiC MahatiC requested a review from a team as a code owner July 11, 2023 12:52
@MahatiC
Copy link
Member Author

MahatiC commented Jul 11, 2023

@anmaxvl @KenGordon ping for a review

KenGordon
KenGordon approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@KenGordon KenGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MahatiC
Replace cosesign1 and didx509 resolver
2229a24 
... with their independent pkgs

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC MahatiC marked this pull request as draft July 12, 2023 16:03
@MahatiC MahatiC marked this pull request as ready for review July 13, 2023 08:33
@MahatiC
Copy link
Member Author

MahatiC commented Jul 13, 2023

I tested this with a payload and infra fragment containers and verified that the fragment is accepted.

@anmaxvl anmaxvl merged commit 43d7af3 into microsoft:main Jul 14, 2023
16 checks passed
@MahatiC MahatiC deleted the replace-repos branch July 14, 2023 16:42
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Aug 16, 2023
@MahatiC @kiashok
Replace cosesign1 and didx509 resolver (microsoft#1805)
858dd27 
... with their independent pkgs

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
(cherry picked from commit 43d7af3)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@MahatiC
Replace cosesign1 and didx509 resolver (microsoft#1805)
91fd253 
... with their independent pkgs

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@anmaxvl anmaxvl anmaxvl approved these changes

@KenGordon KenGordon KenGordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MahatiC @anmaxvl @KenGordon