-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove open-coding of ParentLayerPathsFlag #1917
base: main
Are you sure you want to change the base?
Conversation
7ca06cb
to
eb99b71
Compare
What is |
It's running the repo tests; from what I was able to track down, GitHub is improperly enabling CIMFS in the runners, causing our tests (https://github.com/microsoft/hcsshim/blob/main/pkg/cimfs/cim_test.go) to crash the VM. |
I wouldn't say Github is improperly enabling CIMFS. The host OS version that Github uses for test runners doesn't have full CIMFS support so running tests on those is causing the crash. I will update the tests to not run on these versions. |
eb99b71
to
ae4203f
Compare
containerd/mount.Mount provides an API for this now, although in one case we have to create an instance of that from the protobuf-marshelled types.Mount. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
ae4203f
to
f210c20
Compare
containerd/mount.Mount provides an API for this now, although in one case we have to create an instance of that from the protobuf-marshelled types.Mount.
Something I stumbled across while poking at the containerd image store support for Windows in moby.