Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove open-coding of ParentLayerPathsFlag #1917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TBBle
Copy link
Contributor

@TBBle TBBle commented Sep 24, 2023

containerd/mount.Mount provides an API for this now, although in one case we have to create an instance of that from the protobuf-marshelled types.Mount.

Something I stumbled across while poking at the containerd image store support for Windows in moby.

@TBBle TBBle requested a review from a team as a code owner September 24, 2023 16:19
@TBBle TBBle force-pushed the use_containerd_mount_parents_api branch from 7ca06cb to eb99b71 Compare September 25, 2023 23:03
@TBBle
Copy link
Contributor Author

TBBle commented Sep 29, 2023

What is test-windows (windows-2022)'s "Test repo" step doing, that sometimes it passes in 3 minutes, but usually it runs for half an hour with no logs and then gets a runner-disconnection error? It's been happening on-and-off for a few weeks, and no particular changes jumped out at me in the commit log. (Although apparently such failure is considered a CI pass usually, so maybe it's been happening for longer than that.)

@helsaawy
Copy link
Contributor

helsaawy commented Oct 2, 2023

What is test-windows (windows-2022)'s "Test repo" step doing, that sometimes it passes in 3 minutes, but usually it runs for half an hour with no logs and then gets a runner-disconnection error? It's been happening on-and-off for a few weeks, and no particular changes jumped out at me in the commit log. (Although apparently such failure is considered a CI pass usually, so maybe it's been happening for longer than that.)

It's running the repo tests; from what I was able to track down, GitHub is improperly enabling CIMFS in the runners, causing our tests (https://github.com/microsoft/hcsshim/blob/main/pkg/cimfs/cim_test.go) to crash the VM.

@ambarve
Copy link
Contributor

ambarve commented Oct 2, 2023

What is test-windows (windows-2022)'s "Test repo" step doing, that sometimes it passes in 3 minutes, but usually it runs for half an hour with no logs and then gets a runner-disconnection error? It's been happening on-and-off for a few weeks, and no particular changes jumped out at me in the commit log. (Although apparently such failure is considered a CI pass usually, so maybe it's been happening for longer than that.)

It's running the repo tests; from what I was able to track down, GitHub is improperly enabling CIMFS in the runners, causing our tests (https://github.com/microsoft/hcsshim/blob/main/pkg/cimfs/cim_test.go) to crash the VM.

I wouldn't say Github is improperly enabling CIMFS. The host OS version that Github uses for test runners doesn't have full CIMFS support so running tests on those is causing the crash. I will update the tests to not run on these versions.

@TBBle TBBle force-pushed the use_containerd_mount_parents_api branch from eb99b71 to ae4203f Compare October 18, 2023 12:35
containerd/mount.Mount provides an API for this now, although in one
case we have to create an instance of that from the protobuf-marshelled
types.Mount.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
@TBBle TBBle force-pushed the use_containerd_mount_parents_api branch from ae4203f to f210c20 Compare November 10, 2023 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants