[release/0.8] Backport networking commits #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiashok
approved these changes
Jun 14, 2024
|
@princepereira are the lint errors related to your changes? |
Doesn't look like part of my changes. But let me recheck and get back. |
princepereira
force-pushed
the
user/ppereira/modifyLoadbalancerBackport0.8
branch
2 times, most recently
from
e751fd0
to
eb1159c
Compare
Signed-off-by: Debjit Mondal <debjitmondal@microsoft.com> Signed-off-by: Prince Pereira <ppereira@microsoft.com>
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
Signed-off-by: Prince Pereira <ppereira@microsoft.com>
Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
force-pushed
the
user/ppereira/modifyLoadbalancerBackport0.8
branch
from
eb1159c
to
467f63f
Compare
@kiashok , issue was with some buggy version of golang-lint. I have updated the golang-lint version and now it's working. |
helsaawy
approved these changes
Jun 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are direct ports of the following commits without any additional changes from main to release/0.12 :
c79a631 : #2106 ---> direct cherry-pick
8beabac : #2139 ---> This commit had merge conflicts that were fixed.
0f7d8de : #2085 ---> This commit had merge conflicts that were fixed.