Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing GetCurrentThreadCompartmentId #2384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keithmattix
Copy link

I'm working on a container networking project and noticed this function was missing. I took a stab at adding it, but let me know if changes (or a different approach) is needed.

@keithmattix keithmattix requested a review from a team as a code owner February 21, 2025 04:05
Signed-off-by: keithmattix <keithmattix@microsoft.com>
Signed-off-by: keithmattix <keithmattix@microsoft.com>
@keithmattix keithmattix force-pushed the add-get-current-thread-compartment-id branch from e55b24d to d0d85c7 Compare March 2, 2025 14:22
@helsaawy
Copy link
Contributor

helsaawy commented Mar 3, 2025

Hello,
Will GetCurrentThreadCompartmentId be used by code you are adding here, or to another repo?
Additionally, for container networking code, it might be better to add it to one of the following repos instead:

@keithmattix
Copy link
Author

It will be for code used in another repo: istio/istio. I wasn't aware of hnslib. Is that preferred for these low level APIs?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants