Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI/UX is bad #59

Closed
LatticeMage opened this issue Nov 10, 2023 · 8 comments · Fixed by #197
Closed

UI/UX is bad #59

LatticeMage opened this issue Nov 10, 2023 · 8 comments · Fixed by #197
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@LatticeMage
Copy link

Is your feature request related to a problem? Please describe.
UX is bad, when we see an option, we usually press Enter, not tab due to the UI

Describe the solution you'd like
I think it is better to make the unfinished part is gray and hint user this command is not finished, and use tab to choose the result
image
image

Describe alternatives you've considered
not showing the option list, just gray letters for hint to press tab to fulfill

Additional context
N/A

@LatticeMage LatticeMage added the feature-request Request for new features or functionality label Nov 10, 2023
@cpendery cpendery self-assigned this Nov 10, 2023
@cpendery cpendery added this to the Backlog milestone Nov 10, 2023
@cpendery
Copy link
Member

The ghost text is an interesting idea, but I feel like it gives more a copilot feel than intellisense. I'll look into potentially making this a configurable UI option.

@genie360s
Copy link

I think , we can think it of more like good design practices , rather than relating it to copilot feels , since gmail , also uses the design concept etc.

@theKnightsOfRohan
Copy link

It could also be a good idea to have enter also trigger autocomplete

@genie360s
Copy link

Very true!

@cpendery
Copy link
Member

It could also be a good idea to have enter also trigger autocomplete

If a user doesn't want to accept a submission, would you expect them to hit something like ESC and then enter to run the command? It feels like a breaking experience for most shell users where enter is always execute the command.

@LatticeMage
Copy link
Author

or if there is some setting file let user to choose his/her own key

@theKnightsOfRohan
Copy link

theKnightsOfRohan commented Nov 11, 2023

It could also be a good idea to have enter also trigger autocomplete

If a user doesn't want to accept a submission, would you expect them to hit something like ESC and then enter to run the command? It feels like a breaking experience for most shell users where enter is always execute the command.

Well, inshellisense is simulating actions which most often occur in an ide, and in most ides, that's how the intellisense works. Making it closer to ides would also make it better for your target audience, as most people who would use this plugin (myself included) are not as experienced with shell commands.

One way to improve the experience would be adding some simple settings, like how @LatticeMage said, and/or you could have the UI disappear when using arrow keys to navigate your line.

@cpendery
Copy link
Member

I'll look into making some of the actions, like accepting a suggestion, configurable. For ghost text, it will not be added to inshellisense due to #79. I'm going to allow users to leverage the built in shell suggestions while also viewing inshellisense suggestions, so ghost text will be reserved for the shell's builtin suggestions (zsh-autocomplete, fish, pwsh).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants