Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: make keys map closer to normal IDE intellisense #70

Closed
wants to merge 3 commits into from

Conversation

theKnightsOfRohan
Copy link

@theKnightsOfRohan theKnightsOfRohan commented Nov 12, 2023

Addresses issue #59

Changes

This pull request introduces the following changes:

  1. Added a showSuggestions property to the ui-root component. This property controls the visibility of the suggestions dropdown in the UI.
  2. Added a setShowSuggestions prop to the Input and Suggestions components. This prop is a function that can be used to programmatically control the visibility of the suggestions dropdown.
  3. Added a showSuggestions prop to the Suggestions component, to better control when the autocompletion list should be shown.
  4. Changed key actions. Now, the return key autocompletes terms when the suggestions dropdown is visible, and submits the command when the dropdown is invisible. Also stopped showing the dropdown when the left arrow key or esc key is pressed, to fit with IDE intellisense.

Testing

Please ensure that the changes work as expected and that the suggestions dropdown can be shown and hidden by the intended keys.

Reviewers

Please review this pull request and provide feedback.

@theKnightsOfRohan
Copy link
Author

@microsoft-github-policy-service agree

@theKnightsOfRohan theKnightsOfRohan changed the title Enhance UX to have keys map closer to normal IDE intellisense fix: make keys map closer to normal IDE intellisense Nov 14, 2023
@cpendery
Copy link
Member

Closing this as the keys have diverged quite a bit since this PR was opened. I'll be documenting the new key structure soon

@cpendery cpendery closed this Dec 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants