Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extend ISourceLookUpProvider to be able to specify whether the source is Local (VSCode) or Remote(DAP Server) #515

Merged

Conversation

VladimirMakaev
Copy link
Contributor

Context

I'm building a DAP server based on core package. I.e. without eclipse plugin. Currently it's impossible to set "sourceReference" when returning types in "stacktrace" request.

Having a distinction between Local and Remote sources allows an implementation of ISourceLookUpProvider to instruct the underlying request handlers whether a follow up with "source" request and have it served via getSourceContents

This is also ABI compatible with whoever could implement ISourceLookUpProvider already as current logic is identical to SourceType.Local

Test Plan

I've tested this works with my DAP server

@VladimirMakaev
Copy link
Contributor Author

This should address #259 without breaking changes in current extension, allowing to have a custom implementation of ISourceLookUpProvider as a solution

@VladimirMakaev VladimirMakaev force-pushed the remote-and-local-sources branch from 7086790 to 1fdecdf Compare November 22, 2023 17:02
@testforstephen testforstephen merged commit f8da9e2 into microsoft:main Jan 8, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants