Extend ISourceLookUpProvider to be able to specify whether the source is Local (VSCode) or Remote(DAP Server) #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'm building a DAP server based on
core
package. I.e. without eclipse plugin. Currently it's impossible to set "sourceReference" when returning types in "stacktrace" request.Having a distinction between Local and Remote sources allows an implementation of ISourceLookUpProvider to instruct the underlying request handlers whether a follow up with "source" request and have it served via
getSourceContents
This is also ABI compatible with whoever could implement ISourceLookUpProvider already as current logic is identical to SourceType.Local
Test Plan
I've tested this works with my DAP server