Skip to content

Use Qdrant.Client for QdrantMemory internals #1068

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

russcam
Copy link

@russcam russcam commented May 22, 2025

This commit updates QdrantMemory to use the official Qdrant client for QdrantMemory internals.

I wanted to open a PR at this stage to gauge interest in this change. Further work needed to remove the current client implementation and to test adapters between Kernel memory and Qdrant client is needed.

Motivation and Context (Why the change? What's the scenario?)

  • The official client uses gRPC rather than JSON over REST, with gRPC typically offering a significant overall performance improvement.
  • Official client is maintained by Qdrant, reducing code needing to be maintained in this repository to interface with Qdrant

High level description (Approach, Design)

  • Replace the internal qdrant client implementation with the official Qdrant client, mapping the current client's implementation to methods of the official client.
  • Adapt kernel memory types like MemoryRecord to Qdrant types. There may be opportunities to make this smoother.

This commit updates QdrantMemory to use the official
Qdrant client for QdrantMemory internals.

The official client uses gRPC rather than JSON over REST, with gRPC typically offering a significant overall performance improvement.
@russcam russcam requested a review from dluc as a code owner May 22, 2025 05:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant