Install Command Line Tools as part of Xcode setup #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
americanhanko
requested changes
Mar 25, 2018
libraries/command_line_tools.rb
Outdated
| end | ||
|
|
||
| def available_products | ||
| shell_out('softwareupdate -l').stdout |
There was a problem hiding this comment.
Nit: Break the command into separate arguments and use the long version of the list option?
shell_out('softwareupdate', '--list').stdout
resources/xcode.rb
Outdated
| end | ||
|
|
||
| execute 'install Xcode CLT' do | ||
| command lazy { "softwareupdate --verbose -i '#{CommandLineTools.new}'" } |
There was a problem hiding this comment.
A couple legitimate questions:
- Based on the unit test, do we need to use
CommandLineTools.new.productin the command? - Do we want to be live-streaming here? If not, is the
verboseoption needed?
Nitpicks. Could we:
- extract the command to a list variable for readability (clearer that we need
CommandLineToolsin quotes) - use the long version of the
installoption
execute 'install Xcode CLT' do
install_clt_command = ['softwareupdate', '--install', "'#{CommandLineTools.new}'"]
command lazy { install_clt_command }
action :nothing
notifies :delete, 'file[sentinel to make CLT available]', :immediately
endThere was a problem hiding this comment.
Yep, fixed. And yep, but not with verbose.
There was a problem hiding this comment.
CommandLineTools also is handled by the command array properly (something I hadn't tested before)
| Finding available software | ||
| Software Update found the following new or updated software: | ||
| * Command Line Tools (macOS El Capitan version 10.11) for Xcode-8.2 | ||
| \tCommand Line Tools (macOS El Capitan version 10.11) for Xcode (8.2), 150374K [recommended] |
There was a problem hiding this comment.
Oh, neat. I didn't realize you could use\t for a tab in a heredoc!
There was a problem hiding this comment.
I meant to use <<~ here actually - the tabs make more sense in that context.
americanhanko
approved these changes
Mar 25, 2018
|
Looks great. Thanks for making the changes quickly. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the
xcode-installgem can be installed into Chef gems by verifying that Command Line Tools are installed. If not installed, a temporary file is created to trigger thesoftwareupdate -lcommand into providing the product name for the latest CLT, which is then downloaded and installed.Fixes #79.