Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DDPG parameters update #583

Merged
merged 3 commits into from
Feb 22, 2023
Merged

DDPG parameters update #583

merged 3 commits into from
Feb 22, 2023

Conversation

Jinyu-W
Copy link
Collaborator

@Jinyu-W Jinyu-W commented Feb 22, 2023

Description

  • update DDPG test parameters
  • update seed setting logic in RL tests

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@Jinyu-W Jinyu-W requested a review from lihuoran February 22, 2023 03:45
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #583 (68b1193) into v0.3 (b8a955e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v0.3     #583   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files          86       86           
  Lines        5464     5464           
=======================================
  Hits         4333     4333           
  Misses       1131     1131           
Flag Coverage Δ
unittests 79.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lihuoran lihuoran merged commit f42d5b7 into v0.3 Feb 22, 2023
@lihuoran lihuoran deleted the ddpg_update branch February 22, 2023 04:54
@lihuoran lihuoran restored the ddpg_update branch February 23, 2023 02:32
@lihuoran lihuoran deleted the ddpg_update branch March 28, 2023 03:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants