Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test 'malloc-nomem1' failure on 32-bit architectures after v2.1.4 #882

Closed
MatthewGentoo opened this issue Apr 23, 2024 · 1 comment
Closed

Comments

@MatthewGentoo
Copy link

In mimalloc 2.1.4, malloc-nomem1 in test-api fails.

test: malloc-nomem1...
FAILED: malloc-nomem1: /var/tmp/portage/dev-libs/mimalloc-2.1.4/work/mimalloc-2.1.4/test/test-api.c:77

CHECK_BODY("malloc-nomem1") {
  result = (mi_malloc((size_t)PTRDIFF_MAX + (size_t)1) == NULL);
};

I think that it was broken by 78418b3 (#877). If I edit the huge allocation check at the beginning of mi_find_page back to use PTRDIFF_MAX, the test is passing. However, I'm not sure what the correct behaviour is supposed to be.

@daanx
Copy link
Collaborator

daanx commented May 11, 2024

Should be fixed now :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants