Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add stdatomic.h for gcc-4.8.5 #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shadow-yuan
Copy link

  1. GCC-4.8.5 does not contain the file stdatomic.h, add a similar file (gcc-4.8.5-atomic.h) for compiling in gcc4.8.5
  2. Add option MI_ATOMIC_FOR_GCC485 in cmakelists.txt for this case

@ghost
Copy link

ghost commented Aug 10, 2022

CLA assistant check
All CLA requirements met.

@daanx
Copy link
Collaborator

daanx commented Oct 31, 2022

ah, I feel this adds a lot of complexity (new file, new options etc) for quite a narrow use case. Maybe it is enough to rename the gcc-4.8.5-atomic.h file to stdatomic.h and ensure it is in the include path? That may be enough to make it compile mimalloc as is?

@aengusjiang
Copy link

when merge this pr?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants