-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix for mssql-jdbc.properties
location logic
#2579
Conversation
…utOfBoundsExcelption
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
============================================
+ Coverage 51.22% 51.37% +0.15%
- Complexity 3953 3978 +25
============================================
Files 147 147
Lines 33657 33665 +8
Branches 5624 5627 +3
============================================
+ Hits 17241 17296 +55
+ Misses 13999 13936 -63
- Partials 2417 2433 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
mssql-jdbc.properties
location logicmssql-jdbc.properties
location logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java:287
- The variable 'locationSuffix' is defined but not used consistently. Consider using 'locationSuffix.length()' instead of hardcoding the length value (16) on line 291.
String locationSuffix = "target/classes/";
ADO test runs were good for this change. |
The logic for finding the
mssql-jdbc.properties
file, used in Configurable Retry Logic was correct for test environments, and when building the driver manually, but not correct when using the driver as a jar or dependency. This fixes that issue by only removing thetarget/classes
suffix if needed.