Invalidate existing enclave session during connection (re)connect #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
============================================
- Coverage 51.52% 51.51% -0.01%
+ Complexity 3990 3988 -2
============================================
Files 147 147
Lines 33706 33720 +14
Branches 5631 5636 +5
============================================
+ Hits 17366 17371 +5
- Misses 13886 13894 +8
- Partials 2454 2455 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
Apr 28, 2025
Comment on lines
+2197
to
+2202
| if (enclaveProvider != null) { | ||
| if (connectionlogger.isLoggable(Level.FINE)) { | ||
| connectionlogger.fine("Invalidating existing enclave session for enclave provider : " + enclaveProvider); | ||
| } | ||
| enclaveProvider.invalidateEnclaveSession(); | ||
| } |
There was a problem hiding this comment.
Can this be changed to just call invalidateEnclaveSessionCache() now?
David-Engel
approved these changes
Apr 28, 2025
| @@ -87,7 +89,7 @@ public final class SQLServerException extends java.sql.SQLException { | |||
| static final int DATA_CLASSIFICATION_NOT_EXPECTED = 11; | |||
| static final int DATA_CLASSIFICATION_INVALID_LABEL_INDEX = 12; | |||
| static final int DATA_CLASSIFICATION_INVALID_INFORMATION_TYPE_INDEX = 13; | |||
|
|
|||
There was a problem hiding this comment.
Nit: Stray empty space
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For AE with secure enclave, the driver connections receives an error 33195 - Internal enclave error. Enclave was provided with an invalid session handle. For more information, contact Customer Support Services, post failovers ( in case of Always On setup).
This could be happening because of driver using existing enclave session from the enclaveCache in the driver.
This fix invalidates the existing enclave session as part of the connect method.