[DO NOT MERGE] [PROTOTYPE] Stabilizing PCR4 Measurements #1271
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:breaking-change
Flickdm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1271 +/- ##
==============================================
- Coverage 1.60% 1.60% -0.01%
==============================================
Files 1379 1379
Lines 359694 359702 +8
Branches 5524 5524
==============================================
Hits 5760 5760
- Misses 353827 353835 +8
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Flickdm
commented
Feb 19, 2025
| } else { | ||
| } | ||
| // MU_CHANGE [BEGIN] | ||
| else if (BmIsFvFilePath (BootOption->FilePath)) { |
There was a problem hiding this comment.
Do not measure valid FV files into ReadyToBoot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an effort to stabilize PCR4 measurements.
There are a few known issues with PCR4 measurements that need to be addressed.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
Related Pull Requests
microsoft/mu_plus#637
microsoft/mu_tiano_plus#330
How This Was Tested
Various Boot Paths
Integration Instructions
N/A (TODO)