Revert container updates in 5f3c041 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets up a virtual environment on Linux agents and drops installing pip modules as root. Resolves the following warning issued by Linux build agents since 5f3c041 was committed: "WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv" Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
|
Note: I chose not to use a virtual environment on Windows because there's some known caveats there, example: https://faun.pub/azure-pipelines-and-python-virtual-environments-fdc1089656db And it's not an issue on Windows agents at the moment. |
1 task
cfernald
reviewed
Nov 15, 2022
cfernald
approved these changes
Nov 15, 2022
spbrogan
approved these changes
Nov 15, 2022
Moves pip installation behavior back to what was done before 5f3c041. After analyzing several options, this is the path that most consistently and simply works for container and non-container builds.
makubacki
changed the title
kuqin12
approved these changes
Nov 15, 2022
cfernald
approved these changes
Nov 15, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves pip installation behavior back to what was done before
5f3c041. After analyzing several options, including using virtual
environments, this is the path that most consistently and simply
works for container and non-container builds.
It could potentially be built upon in the future, but it gets all of
the builds functional for now.
Resolves the following warning currently issued by Linux build
agents since 5f3c041 was committed:
"WARNING: Running pip as the 'root' user can result in broken
permissions and conflicting behaviour with the system package
manager.
It is recommended to use a virtual environment instead:
https://pip.pypa.io/warnings/venv"
Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com