Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Introduce a Windbg debugger extension for UEFI platforms #118

Merged
merged 18 commits into from
Nov 4, 2022
Merged

Introduce a Windbg debugger extension for UEFI platforms #118

merged 18 commits into from
Nov 4, 2022

Conversation

cfernald
Copy link
Contributor

@cfernald cfernald commented Nov 2, 2022

No description provided.

@cfernald cfernald requested review from kuqin12, os-d and spbrogan November 2, 2022 21:55
@cfernald cfernald marked this pull request as ready for review November 2, 2022 21:55
@makubacki
Copy link
Member

Can you please add a Readme to the UefiDbgExt directory that describes information like applicability, limitations, basic usage, and theory of operation (e.g. memory scanning details, etc.)?

makubacki
makubacki reviewed Nov 3, 2022
View reviewed changes
.github/workflows/Build-UefiExt.yaml Outdated Show resolved Hide resolved
UefiDbgExt/dbgexts.cpp Outdated Show resolved Hide resolved
@cfernald
Copy link
Contributor Author

cfernald commented Nov 3, 2022

Can you please add a Readme to the UefiDbgExt directory that describes information like applicability, limitations, basic usage, and theory of operation (e.g. memory scanning details, etc.)?

Hey, there is already a readme, but I'll add some of the details you mentioned!

cfernald
cfernald commented Nov 3, 2022
View reviewed changes
UefiDbgExt/memory.cpp Outdated Show resolved Hide resolved
kuqin12
kuqin12 approved these changes Nov 3, 2022
View reviewed changes
UefiDbgExt/readme.md Show resolved Hide resolved
@makubacki
Copy link
Member

Can you please add a Readme to the UefiDbgExt directory that describes information like applicability, limitations, basic usage, and theory of operation (e.g. memory scanning details, etc.)?

Hey, there is already a readme, but I'll add some of the details you mentioned!

Thanks UefiDbgExt/readme.md covers what I was looking for

@cfernald cfernald merged commit cec471f into microsoft:main Nov 4, 2022
@out0xb2
Copy link
Contributor

out0xb2 commented Dec 28, 2022

This is super-cool! Still a fan from afar!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kuqin12 kuqin12 kuqin12 approved these changes

@makubacki makubacki makubacki approved these changes

@os-d os-d Awaiting requested review from os-d

@spbrogan spbrogan Awaiting requested review from spbrogan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfernald @makubacki @out0xb2 @kuqin12