Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QemuRunner.py: Allow OS image paths with spaces #247

Merged

Conversation

makubacki
Copy link
Member

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

Wraps the -hda path given to QEMU with quotes so it can contain spaces.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested with paths to OS images that include spaces in the path.

Integration Instructions

N/A

Wraps the `-hda` path given to QEMU with quotes so it can contain
spaces.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Jan 23, 2023
@makubacki makubacki merged commit 0935862 into microsoft:main Jan 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants