Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QemuQ35Pkg: Fix CI failures from refactor #80

Merged
merged 2 commits into from
Oct 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azurepipelines/Ubuntu-GCC5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ resources:
trigger: none

pr:
- dev/*
- release/*
- main
- release/202202

jobs:
- template: Jobs/PrGate.yml@mu_devops
Expand Down
4 changes: 2 additions & 2 deletions .azurepipelines/Windows-VS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ resources:
trigger: none

pr:
- dev/*
- release/*
- main
- release/202202

jobs:
- template: Jobs/PrGate.yml@mu_devops
Expand Down
6 changes: 4 additions & 2 deletions Platforms/QemuQ35Pkg/.azurepipelines/Ubuntu-GCC5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ resources:
ref: main

trigger:
- release/*
- main
- release/202202

pr:
- release/*
- main
- release/202202

jobs:
- job: Platform_CI
Expand Down
6 changes: 4 additions & 2 deletions Platforms/QemuQ35Pkg/.azurepipelines/Windows-VS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ resources:
ref: main

trigger:
- release/*
- main
- release/202202

pr:
- release/*
- main
- release/202202

jobs:
- job: Platform_CI
Expand Down
4 changes: 2 additions & 2 deletions Platforms/QemuQ35Pkg/QemuQ35Pkg.ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@

## options defined .pytool/Plugin/GuidCheck
"GuidCheck": {
"IgnoreGuidName": [], # Expected duplication for gEfiFirmwareVolumeTopFileGuid
"IgnoreGuidName": ["SecCore", "ResetVector"], # Expected duplication for gEfiFirmwareVolumeTopFileGuid
"IgnoreGuidValue": [],
"IgnoreFoldersAndFiles": [],
"IgnoreDuplicates": [],
Expand All @@ -80,7 +80,7 @@

## options defined .pytool/Plugin/SpellCheck
"SpellCheck": {
"AuditOnly": False, # Fails right now with over 270 errors
"AuditOnly": True, # Enable after fixing failures
"IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
"ExtendWords": [
"acpitable",
Expand Down
34 changes: 33 additions & 1 deletion Platforms/QemuQ35Pkg/QemuQ35Pkg.dec
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,31 @@
Include

[LibraryClasses]
## @libraryclass Verify blobs read from the VMM
BlobVerifierLib|Include/Library/BlobVerifierLib.h

## @libraryclass Declares helper functions for Secure Encrypted
# Virtualization (SEV) guests.
MemEncryptSevLib|Include/Library/MemEncryptSevLib.h

## @libraryclass Provides services to work with PCI capabilities in PCI
# config space.
PciCapLib|Include/Library/PciCapLib.h

## @libraryclass Layered on top of PciCapLib, allows clients to plug an
# EFI_PCI_IO_PROTOCOL backend into PciCapLib, for config
# space access.
PciCapPciIoLib|Include/Library/PciCapPciIoLib.h

## @libraryclass Layered on top of PciCapLib, allows clients to plug a
# PciSegmentLib backend into PciCapLib, for config space
# access.
PciCapPciSegmentLib|Include/Library/PciCapPciSegmentLib.h

## @libraryclass Provide common utility functions to PciHostBridgeLib
# instances in ArmVirtPkg and OvmfPkg.
PciHostBridgeUtilityLib|Include/Library/PciHostBridgeUtilityLib.h

## @libraryclass Access QEMU's firmware configuration interface
#
QemuFwCfgLib|Include/Library/QemuFwCfgLib.h
Expand All @@ -30,6 +51,17 @@
#
QemuFwCfgS3Lib|Include/Library/QemuFwCfgS3Lib.h

## @libraryclass Parse the contents of named fw_cfg files as simple
# (scalar) data types.
QemuFwCfgSimpleParserLib|Include/Library/QemuFwCfgSimpleParserLib.h

## @libraryclass Declares utility functions for virtio device drivers.
VirtioLib|Include/Library/VirtioLib.h

## @libraryclass Get information about Xen
#
XenPlatformLib|Include/Library/XenPlatformLib.h

[Guids]
## Policy GUID for GFX policy data
#
Expand Down Expand Up @@ -96,7 +128,7 @@
# boundary limitations apply.
# @Prompt UI Front Page File
gQemuQ35PkgTokenSpaceGuid.PcdUIApplicationFile|{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }|VOID*|0x00000001

gUefiQemuQ35PkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|0x0|UINT32|0
gUefiQemuQ35PkgTokenSpaceGuid.PcdOvmfPeiMemFvSize|0x0|UINT32|1
gUefiQemuQ35PkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|0x0|UINT32|0x15
Expand Down
2 changes: 1 addition & 1 deletion Platforms/QemuQ35Pkg/SataControllerDxe/SataController.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ CalculateBestUdmaMode (
DeviceUDmaMode = IdentifyData->AtaData.ultra_dma_mode;
DEBUG ((DEBUG_INFO, "CalculateBestUdmaMode: DeviceUDmaMode = %x\n", DeviceUDmaMode));
DeviceUDmaMode &= 0x3f;
QemuQ35PkgMode = 0; // initialize it to UDMA-0
QemuQ35PkgMode = 0; // initialize it to UDMA-0

while ((DeviceUDmaMode >>= 1) != 0) {
QemuQ35PkgMode++;
Expand Down
8 changes: 4 additions & 4 deletions Platforms/QemuQ35Pkg/SioBusDxe/SioService.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,10 @@ SioCreateChildDevice (
//
mAcpiDeviceNodeQemuQ35Pkglate.HID = mDevicesInfo[DeviceIndex].Hid;
mAcpiDeviceNodeQemuQ35Pkglate.UID = mDevicesInfo[DeviceIndex].Uid;
SioDevice->DevicePath = AppendDevicePathNode (
ParentDevicePath,
(EFI_DEVICE_PATH_PROTOCOL *)&mAcpiDeviceNodeQemuQ35Pkglate
);
SioDevice->DevicePath = AppendDevicePathNode (
ParentDevicePath,
(EFI_DEVICE_PATH_PROTOCOL *)&mAcpiDeviceNodeQemuQ35Pkglate
);
if (SioDevice->DevicePath == NULL) {
Status = EFI_OUT_OF_RESOURCES;
goto Done;
Expand Down