Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enable CapsuleLib in Q35 #83

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Enable CapsuleLib in Q35 #83

merged 2 commits into from
Oct 20, 2022

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Oct 13, 2022 •
edited
Loading

QemuQ35 uses CapsuleLibNull which causes it to fail the RuntimeServicesTest.MiscRuntimeServicesTest.UpdateCapsule_Conf SCT as StageCapsuleImage() would always return EFI_UNSUPPORTED. Enabling CapsuleLib allows the normal capsule update process to be evaluated by the SCTs.

@makubacki makubacki requested a review from TaylorBeebe October 14, 2022 19:28
@makubacki
Copy link
Member

Could you please provide some detail in the PR description?

@Javagedes
Copy link
Contributor Author

Could you please provide some detail in the PR description?

Updated. Thanks!

@makubacki
Copy link
Member

@Javagedes, the PR is still targeting release/202202. Do you want that or main now?

@makubacki makubacki requested a review from kuqin12 October 14, 2022 19:48
@Javagedes Javagedes changed the base branch from release/202202 to main October 14, 2022 19:54
@Javagedes
Copy link
Contributor Author

@Javagedes, the PR is still targeting release/202202. Do you want that or main now?

main. I've updated as such. Thanks again!

@makubacki makubacki self-requested a review October 14, 2022 19:55
@Javagedes
Copy link
Contributor Author

@Javagedes, the PR is still targeting release/202202. Do you want that or main now?

main. I've updated as such. Thanks again!

@makubacki I need to fix a few conflicts and push a new commit so the pipelines kick off again.

@Javagedes
Copy link
Contributor Author

@Javagedes, the PR is still targeting release/202202. Do you want that or main now?

main. I've updated as such. Thanks again!

@makubacki I need to fix a few conflicts and push a new commit so the pipelines kick off again.

Rebased. Pipelines are running.

@Javagedes Javagedes merged commit 1b235ec into microsoft:main Oct 20, 2022
@Javagedes Javagedes deleted the personal/joeyvagedes/enable_capsulelib branch October 20, 2022 22:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kuqin12 kuqin12 kuqin12 approved these changes

@makubacki makubacki makubacki approved these changes

@TaylorBeebe TaylorBeebe Awaiting requested review from TaylorBeebe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Javagedes @makubacki @kuqin12