Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: update nan@2.17.0 #567

Merged
merged 1 commit into from
Nov 15, 2022
Merged

chore: update nan@2.17.0 #567

merged 1 commit into from
Nov 15, 2022

Conversation

deepak1556
Copy link
Contributor

Brings in nodejs/nan@7f9ceb8 which is required for microsoft/vscode#166265

Additionally,

  • Removes peer dependency on node-gyp since it is not required
  • Updates build matrix

@deepak1556 deepak1556 merged commit f2f1a8e into main Nov 15, 2022
@deepak1556 deepak1556 deleted the robo/update_nan branch November 15, 2022 16:08
@Tyriar Tyriar added this to the 1.0.0 milestone Nov 15, 2022
@valeriangalliat valeriangalliat mentioned this pull request Mar 14, 2023
Closed
@deepak1556 deepak1556 mentioned this pull request May 3, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @lramos15 @Tyriar