[WebNN EP] Validate MLContext creation early to allow fallback to other EP #20735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sansmoraxz
reviewed
May 20, 2024
Comment on lines
+122
to
+124
| if (backendNames.filter(name => name === 'webnn').length > 1) { | ||
| throw new Error(`Registering duplicate 'webnn' backends in the session options is not permitted`); | ||
| } |
There was a problem hiding this comment.
Will this disable trying do this?
executionProviders: [
{
name: "webnn",
deviceType: "gpu",
},
{
name: "webnn",
deviceType: "cpu",
},
...
]There was a problem hiding this comment.
Creating multiple WebNN or WebGPU eps in a single session is not allowed, @fs-eire, right?
There was a problem hiding this comment.
I don't know if that is possible or not technically. But in practice, I think there is no use case of multiple instances of the same EP being used in one session.
guschmue
added
ep:WebGPU
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix issue #20729