New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: waitForCondition should not call predicate after it returned true #1721

Merged

yury-s merged 1 commit into microsoft:main from yury-s:waitForCondition-idempotent

Dec 19, 2024

Member

yury-s commented Dec 19, 2024

Previously it would fail with this exception:

java.lang.AssertionError
	at com.microsoft.playwright.impl.WaitableRace.get(WaitableRace.java:40)
	at com.microsoft.playwright.impl.ChannelOwner.runUntil(ChannelOwner.java:132)
	at com.microsoft.playwright.impl.BrowserContextImpl.waitForCondition(BrowserContextImpl.java:670)
	at com.microsoft.playwright.BrowserContext.waitForCondition(BrowserContext.java:1545)


          fix: waitForCondition should not call predicate after it returned true

d6a181e

pavelfeldman approved these changes

View reviewed changes

yury-s merged commit 42d0203 into microsoft:main

12 of 19 checks passed

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet