Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test coverage plan #7

Closed
34 tasks done
pavelfeldman opened this issue Jul 7, 2020 · 1 comment · Fixed by #157
Closed
34 tasks done

Test coverage plan #7

pavelfeldman opened this issue Jul 7, 2020 · 1 comment · Fixed by #157

Comments

@pavelfeldman
Copy link
Member

pavelfeldman commented Jul 7, 2020

  • browser
  • defaultbrowsercontext wip

  • cookies
  • emulation
  • dispatchevent
  • headful
  • dialog
  • focus
  • geolocation
  • accessibility
  • add_init_script
  • browsercontext
  • check
  • click
  • console
  • download
  • element_handle
  • evaluate
  • fill
  • frames
  • generation
  • ignore_https_errors
  • input
  • interception
  • jshandle
  • keyboard
  • launcher
  • navigation
  • network
  • page
  • pdf
  • popup
  • queryselector
  • worker
@mxschmitt
Copy link
Member

mxschmitt commented Jul 9, 2020

missing tests

inputs.spec.js

  • should detect mime type
  • should respect timeout
  • should respect default timeout when there is no custom timeout
  • should prioritize exact timeout over default timeout
  • should work with no timeout

reason: timeout needs to be implemented and setRoute too on the mockserver.

downloads.spec.js

  • should expose stream

network.spec.js

keyboard.spec.js

  • mostly missing
  • [x]Request.postDataJSON is missing

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants