Skip to content

fix: setDefaultTimeout #120

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

fix: setDefaultTimeout #120

merged 1 commit into from
Aug 1, 2020

Conversation

mxschmitt
Copy link
Member

Fixes #114

@coveralls
Copy link

coveralls commented Aug 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 191412318

  • 6 of 13 (46.15%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 88.051%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/sync_api.py 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
playwright/connection.py 1 97.62%
Totals Coverage Status
Change from base Build 190969898: 0.04%
Covered Lines: 3353
Relevant Lines: 3808
💛 - Coveralls

@mxschmitt mxschmitt force-pushed the bugfix/set_default_timeout branch from 94a6401 to 7c34e22 Compare August 1, 2020 10:58
pavelfeldman
pavelfeldman reviewed Aug 1, 2020
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix generators instead?

@mxschmitt mxschmitt force-pushed the bugfix/set_default_timeout branch from 7c34e22 to 1f9ef3a Compare August 1, 2020 17:48
@pavelfeldman pavelfeldman merged commit 8c937ba into microsoft:master Aug 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Page.setDefaultTimeout does not work in sync mode
3 participants
@mxschmitt @coveralls @pavelfeldman