Skip to content

test: add missing dispatch event tests #130

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

test: add missing dispatch event tests #130

merged 1 commit into from
Aug 4, 2020

Conversation

rwoll
Copy link
Member

@rwoll rwoll commented Aug 2, 2020

No description provided.

@rwoll rwoll changed the title test: add failing dispatch event tests test: add missing dispatch event tests Aug 2, 2020
rwoll
rwoll commented Aug 2, 2020
View reviewed changes
rwoll
rwoll commented Aug 2, 2020
View reviewed changes
@rwoll rwoll force-pushed the test/dispatch-event branch from 7855bb4 to b823dda Compare August 3, 2020 00:00
@rwoll rwoll requested a review from pavelfeldman August 3, 2020 00:03
rwoll
rwoll commented Aug 3, 2020
View reviewed changes
@coveralls
Copy link

coveralls commented Aug 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 194182578

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 89.027%
Files with Coverage Reduction New Missed Lines %
playwright/connection.py 1 97.62%
Totals Coverage Status
Change from base Build 194173457: 0.1%
Covered Lines: 3497
Relevant Lines: 3928
💛 - Coveralls

@rwoll rwoll marked this pull request as ready for review August 4, 2020 02:02
@rwoll rwoll force-pushed the test/dispatch-event branch from 7935cd6 to dd759c1 Compare August 4, 2020 02:58
mxschmitt
mxschmitt approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for digging into it!

@pavelfeldman pavelfeldman merged commit 1870817 into microsoft:master Aug 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@pavelfeldman pavelfeldman Awaiting requested review from pavelfeldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwoll @coveralls @pavelfeldman @mxschmitt