Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "fix(test runner): align with typescript behaviour for resolving index.js and package.json through path mapping (#32078)" #32492

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 6, 2024

This reverts commit effb1ae.

This broke path mapping into directories in ESM mode. References #32480.

…ng `index.js` and `package.json` through path mapping (microsoft#32078)"

This reverts commit effb1ae.
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Test results for "tests 1"

2 failed
❌ [installation tests] › playwright-cdn.spec.ts:41:7 › playwright cdn failover should work (https://playwright.azureedge.net)
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

1 flaky ⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config

29571 passed, 629 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 1402dee into microsoft:main Sep 6, 2024
28 of 30 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Sep 11, 2024
…pescript behaviour for resolving `index.js` and `package.json` through path mapping (microsoft#32078)"

This reverts commit effb1ae.

This broke path mapping into directories in ESM mode. References microsoft#32480.
dgozman added a commit that referenced this pull request Sep 11, 2024
#32560)

…behaviour for resolving `index.js` and `package.json` through path
mapping (#32078)"

This reverts commit effb1ae.

This broke path mapping into directories in ESM mode. References #32480.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant