Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: note that permissions list may change #33690

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Nov 20, 2024

Also remove 'accessibility-events' from the list as it is not supported by any browser anymore.

References #33678.

Also remove 'accessibility-events' from the list as it is
not supported by any browser anymore.
Copy link
Contributor

Test results for "tests 1"

3 flaky ⚠️ [chromium-page] › page/page-event-request.spec.ts:138:3 › should report navigation requests and responses handled by service worker with routing @chromium-ubuntu-22.04-node20
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18

37128 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

A list of permissions to grant.

:::danger
Supported permissions differ between browsers, and even between different versions of the same browser. Any permission may stop working after an update.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I tried to give them a workaround with newCDPSession in order to grant custom permissions - for some reason it didn't work for me. Maybe it would make sense to give it to them aka. put it into the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we are interested in this usecase, but if someone files an issue about it, feel free to respond.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants