-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix alstm models and the corresponding yaml documents #1575
Open
hellowordma
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
hellowordma:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the rnn_type from GRU to LSTM as it should be
change the rnn_type from GRU to LSTM as its should be
Update workflow_config_alstm_Alpha360.yaml
Update workflow_config_alstm_Alpha158.yaml
To make it possible to pass parameter of rnn_type. Otherwise, whatever rnn_type you choose, the code will adopt the default type --GRU model. This is an ALSTM model, instead of A-GRU model
To make it possible to pass parameter of rnn_type. Otherwise, whatever rnn_type you choose, the code will adopt the default type --GRU model. This is an ALSTM model, instead of A-GRU model
Update pytorch_alstm.py
github-actions
bot
added
the
waiting for triage
Cannot auto-triage, wait for triage.
label
Jun 29, 2023
@microsoft-github-policy-service agree |
Hi, I think there are three points that need to be looked at.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make it possible to pass parameter of rnn_type. Otherwise, whatever rnn_type you choose, the code will adopt the default type --GRU model. This is an ALSTM model, instead of A-GRU model
Motivation and Context
To make it possible to pass parameter of rnn_type
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
Types of changes