[Fabric] add support for enableFocusRing #11323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
approved these changes
Mar 2, 2023
acoates-ms
added
the
AutoMerge
vmoroz
approved these changes
Mar 7, 2023
This was referenced Mar 22, 2023
158 tasks
jonthysell
added
the
New Architecture
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enableFocusRingis a property to display native focus visualization. This adds support for that property. For now, it's using a simple black rect. In future this should be updated to align with windows visuals (Ex: rounded rect with black/white border)This involved creating an extra container visual around views so that the focus rect can be outside the views clip (Ex: a view with a rounded rect would clip the focus rect if the focus rect was within the view's visual)
Also fixed some logic in the
walkTreemethod, now that I can see focus it became clearer that I completely messed up the first implementation.Added handling of the focus command, so now
ref.focus()works.Microsoft Reviewers: Open in CodeFlow