Stop disabling warning 4244 because BinSkim fails if it sees one #14258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes all instances where we ignore warning 4244 (loss of data when casting double to int) because BinSkim won't let us pass compliance when that happens. Closes microsoft#14251
acoates-ms
approved these changes
Jan 8, 2025
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Jan 8, 2025
…rosoft#14258) ## Description This PR removes all instances where we ignore warning 4244 (loss of data when casting double to int) because BinSkim won't let us pass compliance when that happens. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why Compliance, fix publish, see above. Closes microsoft#14251 ### What See above. ## Screenshots N/A ## Testing N/A ## Changelog Should this change be included in the release notes: _yes_ Stop disabling warning 4244 because BinSkim fails if it sees one
jonthysell
added a commit
that referenced
this pull request
Jan 8, 2025
) (#14260) ## Description This PR removes all instances where we ignore warning 4244 (loss of data when casting double to int) because BinSkim won't let us pass compliance when that happens. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why Compliance, fix publish, see above. Closes #14251 ### What See above. ## Screenshots N/A ## Testing N/A ## Changelog Should this change be included in the release notes: _yes_ Stop disabling warning 4244 because BinSkim fails if it sees one
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all instances where we ignore warning 4244 (loss of data when casting double to int) because BinSkim won't let us pass compliance when that happens.
Type of Change
Why
Compliance, fix publish, see above.
Closes #14251
What
See above.
Screenshots
N/A
Testing
N/A
Changelog
Should this change be included in the release notes: yes
Stop disabling warning 4244 because BinSkim fails if it sees one
Microsoft Reviewers: Open in CodeFlow