Ruby bindings for existing FFI methods, plus eval_rule() #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
anakrish
reviewed
Mar 31, 2024
|
Looks great, especially if this is the first time with Rust! |
…DME.md also added rubocop-minitest and rubocop-rake, and added more test coverage
thedavemarshall
changed the title
anakrish
approved these changes
Apr 1, 2024
| @@ -0,0 +1,180 @@ | |||
| # frozen_string_literal: true | |||
|
I have created an issue #191. You could also update the bindings section of the main README.md |
|
There are a few other things I haven't gotten to yet besides adding the Ruby bindings tests to the github actions, but I think these could each be followup PRs.
@anakrish thank you so much for the feedback! |
|
@thedavemarshall I will go ahead and merge the PR. The remaining items including the github action could be done as separate PRs. |
Interesting! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few things left to figure out, but I wanted to get some early feedback on my first time wring Rust. Feedback is welcome!
The other thing I'd call out is that I ran into some issues with a circular build when I had thebindings/ruby/ext/regorusrb/Cargo.tomldepend on the relative location ofregorus, so I locked it to0.1.2. Other language bindings seem to work with the relative paths, I think this might be something to do with the other manifest atbindings/ruby/Cargo.toml? Not sure if resolving this is a blocker or if we can manually update the versions as needed for each release.Update- I think I got it to work with relative paths for the crate!
The other callout is that rubygems expects a
Cargo.lockfile to be included, source, which in this case is the top level regorus crate's Cargo.lock