Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cli): automatically compose source maps for Hermes bundle #2915

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix(cli): automatically compose source maps for Hermes bundle #2915

merged 1 commit into from
Jan 17, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 9, 2024 •
edited
Loading

Description

Automatically compose source maps of the JS bundle and Hermes bytecode bundle.

Test plan

cd packages/test-app
yarn build --dependencies
yarn bundle+esbuild --dev false --platform android

Verify that dist/main+esbuild.android.hbc.map points to source files instead of dist/main+esbuild.android.bundle

@github-actions github-actions bot added the feature: cli This is related to CLI label Jan 9, 2024
@tido64 tido64 force-pushed the tido/combine-hbc-sourcemaps branch from 357d723 to 99c0f6b Compare January 9, 2024 18:45
@tido64 tido64 changed the title fix(cli): automatically combine sourcemaps for Hermes bundle fix(cli): automatically compose sourcemaps for Hermes bundle Jan 9, 2024
@tido64 tido64 changed the title fix(cli): automatically compose sourcemaps for Hermes bundle fix(cli): automatically compose source maps for Hermes bundle Jan 9, 2024
@tido64 tido64 force-pushed the tido/combine-hbc-sourcemaps branch from 99c0f6b to 996348f Compare January 10, 2024 11:34
@tido64 tido64 marked this pull request as ready for review January 16, 2024 15:36
@adamivancza
Copy link

Can confirm that this fixed our issue: #2909. Thank you @tido64 🥇

@tido64
Copy link
Member Author

tido64 commented Jan 17, 2024

Can confirm that this fixed our issue: #2909. Thank you @tido64 🥇

Thanks for confirming!

kelset
kelset approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM; tested locally and it works fine, and we already have the confirmation that it works. Let's :shipit:

@tido64 tido64 merged commit afe49c6 into main Jan 17, 2024
12 checks passed
@tido64 tido64 deleted the tido/combine-hbc-sourcemaps branch January 17, 2024 11:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kelset kelset kelset approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: cli This is related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tido64 @adamivancza @kelset