chore: bump react-native to 0.74
#3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature: metro
This was referenced Aug 13, 2024
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 13, 2024
Summary:
Android fails to build in a pnpm monorepo setup because `yargs` cannot be found:
```
% yarn android
info Installing the app...
> Configure project :app
WARNING: The option setting 'android.jetifier.ignorelist=hermes-android' is experimental.
Signing config for 'release' build type not found; reusing debug config
> Task :react-native-webapis_web-storage:generateCodegenSchemaFromJavaScript FAILED
28 actionable tasks: 6 executed, 22 up-to-date
node:internal/modules/cjs/loader:1148
throw err;
^
Error: Cannot find module 'yargs'
Require stack:
- /~/node_modules/.store/react-native-codegen-virtual-39ff8dcc54/package/lib/cli/combine/combine-js-to-schema-cli.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
at Module._load (node:internal/modules/cjs/loader:986:27)
at Module.require (node:internal/modules/cjs/loader:1233:19)
at require (node:internal/modules/helpers:179:18)
```
## Changelog:
[GENERAL] [FIXED] - Fix codegen failing in a pnpm monorepo because of missing `yargs`
Pull Request resolved: #45994
Test Plan: Tested in microsoft/rnx-kit#3290
Reviewed By: dmytrorykun
Differential Revision: D61201420
Pulled By: cortinico
fbshipit-source-id: aac3704ae7f200db827b14c8362f83a5e66ad08e
acoates-ms
approved these changes
Aug 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump React Native to 0.74.
react-native-macoswas also removed so that we can bump to 0.75 next week.Test plan
CI should pass.