-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
.Net: Sync to MEAI 9.3.0-preview.1.25114.11 #10989
Conversation
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatClientChatCompletionService.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.UnitTests/AI/ServiceConversionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
Thanks! You beat me to it. I was waiting for a new build of ONNXRuntimeGenAI to be available, as I expect there will be versioning issues without that. It's supposed to be out today. |
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatClientChatCompletionService.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/KernelContent.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/BinaryContent.cs
Outdated
Show resolved
Hide resolved
@markwallace-microsoft, @RogerBarreto, are there known issues with the Process tests? I'm not familiar with that part of the codebase, but it's not clear to me why it would be impacted at all by the changes in this PR. |
dotnet/src/Connectors/Connectors.Ollama.UnitTests/Services/OllamaChatCompletionTests.cs
Outdated
Show resolved
Hide resolved
I saw that, will have a look, thought the same |
The PR is building now. We should definitely revisit the 512e76b commit, though, after today's release is unblocked. It seems like there's some kind of conflict in the OllamaSharp package due to it carrying a source generator that depends on versions of compiler binaries that are incompatible with other aspect's of the repo's build. This was the way I found to temporarily work around it (other things I tried like excluding the analyzer assets for OllamaSharp were insufficient), but I don't like it as a longer-term solution. |
A good review would be much appreciated, including considering the higher-level implications of the MEAI-side change for SK (I know very little about SK outside of MEVD!). See specific comments below.