Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

.Net: Sync to MEAI 9.3.0-preview.1.25114.11 #10989

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

roji
Copy link
Member

@roji roji commented Mar 14, 2025

A good review would be much appreciated, including considering the higher-level implications of the MEAI-side change for SK (I know very little about SK outside of MEVD!). See specific comments below.

@roji roji requested a review from a team as a code owner March 14, 2025 20:50
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 14, 2025
@github-actions github-actions bot changed the title Sync to MEAI 9.3.0-preview.1.25114.11 .Net: Sync to MEAI 9.3.0-preview.1.25114.11 Mar 14, 2025
@stephentoub
Copy link
Member

Sync to MEAI 9.3.0-preview.1.25114.11

Thanks! You beat me to it. I was waiting for a new build of ONNXRuntimeGenAI to be available, as I expect there will be versioning issues without that. It's supposed to be out today.

@stephentoub
Copy link
Member

@markwallace-microsoft, @RogerBarreto, are there known issues with the Process tests? I'm not familiar with that part of the codebase, but it's not clear to me why it would be impacted at all by the changes in this PR.

@RogerBarreto
Copy link
Member

are there known issues with the Process tests? I'm not familiar with that part of the codebase

I saw that, will have a look, thought the same

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Mar 18, 2025
@stephentoub
Copy link
Member

The PR is building now. We should definitely revisit the 512e76b commit, though, after today's release is unblocked. It seems like there's some kind of conflict in the OllamaSharp package due to it carrying a source generator that depends on versions of compiler binaries that are incompatible with other aspect's of the repo's build. This was the way I found to temporarily work around it (other things I tried like excluding the analyzer assets for OllamaSharp were insufficient), but I don't like it as a longer-term solution.

Merged via the queue into microsoft:main with commit ea00f4f Mar 18, 2025
20 checks passed
@roji roji deleted the NewMEAI branch March 18, 2025 16:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants