Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Python: Revert "Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi…" #2531

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

awharrison-28
Copy link
Contributor

Reverts #2435

This PR caused a breaking change to the ACS memory store's get_nearest_matches method

@awharrison-28 awharrison-28 requested a review from a team as a code owner August 22, 2023 19:05
@shawncal shawncal added python Pull requests for the Python Semantic Kernel memory connector labels Aug 22, 2023
@github-actions github-actions bot changed the title Revert "Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi…" Python: Revert "Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi…" Aug 22, 2023
Copy link
Contributor

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hold on for a sec before merging

Copy link
Contributor

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int. tests verified are passing

@dluc dluc added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit f0ab0fb Aug 22, 2023
@dluc dluc deleted the revert-2435-main branch August 22, 2023 19:53
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
…ctorSearchAlgorithmConfi…" (microsoft#2531)

Reverts microsoft#2435

This PR caused a breaking change to the ACS memory store's
get_nearest_matches method
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
memory connector python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants