Skip to content

Conversation

nwf-msr
Copy link
Contributor

@nwf-msr nwf-msr commented Jun 10, 2022

Otherwise, on platforms for which {,u}intptr_t aren't just typedef-s of
other scalar types, it's ambiguous which way an implicit cast should go.

@nwf-msr nwf-msr requested a review from davidchisnall June 10, 2022 15:16
@nwf-msr
Copy link
Contributor Author

nwf-msr commented Jun 10, 2022

With this and the SNMALLOC_LINK_ICF=OFF hack, all four of {debug, release} x {hybrid, purecap} build in Morello CI.

Copy link
Collaborator

@davidchisnall davidchisnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a similar fix locally to this that casts to void* in both cases. This is probably closer to the right thing because then we can print the full capability in the void* case.

Otherwise, on platforms for which {,u}intptr_t aren't just typedef-s of
other scalar types, it's ambiguous which way an implicit cast should go.
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwf-msr nwf-msr merged commit 467c28b into microsoft:main Jun 21, 2022
@nwf-msr nwf-msr deleted the 202206-append-intptr branch June 21, 2022 16:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants